michaelandrepearce commented on a change in pull request #2749: ARTEMIS-2408
Too many opened FDs after server stops
URL: https://github.com/apache/activemq-artemis/pull/2749#discussion_r303672207
##########
File path:
artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
##########
@@ -171,6 +171,9 @@
@ClassRule
public static ThreadLeakCheckRule leakCheckRule = new ThreadLeakCheckRule();
+ @Rule
+ public NoFDBehind noFDBehind = new NoFDBehind(-1, 1000);
Review comment:
Whats FD, i can guess due to context of this PR, but the point is, i
shouldnt have to guess and in future without PR context it will be harder to
guess, please avoid using acronym or shorthand, for others readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
