franz1981 commented on a change in pull request #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#discussion_r303785677
########## File path: tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/jmx/JmxConnectionTest.java ########## @@ -27,8 +27,8 @@ import java.rmi.server.RemoteRef; import io.netty.util.internal.PlatformDependent; -import io.netty.util.internal.shaded.org.jctools.util.UnsafeAccess; import org.apache.activemq.artemis.tests.smoke.common.SmokeTestBase; +import org.jctools.util.UnsafeAccess; Review comment: We are working on a VarHandle version and we already allows different AtomicXXX versions to be used (with a small perf drop): probably java 12 is fine too, but I haven't tested it personally... The problem will be when some Unsafe specific methods will be scattered around VarHandle/Other classes and will be officially deleted from Unsafe... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
