HavretGC commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization URL: https://github.com/apache/activemq-nms-openwire/pull/9#discussion_r304247060
########## File path: test/nms-openwire-test.csproj ########## @@ -0,0 +1,66 @@ +<Project Sdk="Microsoft.NET.Sdk"> + + <PropertyGroup> + <TargetFramework>netcoreapp2.2</TargetFramework> Review comment: Not sure if there is need to publish tests as nuget package at all. It makes sens for nms api (as we wan't to run it against implementation), but here I don't see any point in it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
