clebertsuconic commented on a change in pull request #2759: ARTEMIS-2408 Too
many opened FDs after server stops
URL: https://github.com/apache/activemq-artemis/pull/2759#discussion_r304568592
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java
##########
@@ -407,15 +408,28 @@ public void stop(final boolean criticalError) throws
Exception {
conn.disconnect(criticalError);
}
+ Map<Acceptor, Future<?>> acceptorFutures = new HashMap<>();
for (Acceptor acceptor : acceptors.values()) {
try {
- acceptor.stop();
+ acceptorFutures.put(acceptor, acceptor.asyncStop());
} catch (Throwable t) {
ActiveMQServerLogger.LOGGER.errorStoppingAcceptor(acceptor.getName());
}
}
+ long acceptorTimeout = System.currentTimeMillis() + 3000;
+ for (Map.Entry<Acceptor, Future<?>> acceptorFuture :
acceptorFutures.entrySet()) {
+ if (acceptorFuture.getValue() != null) {
+ try {
+ acceptorFuture.getValue().get(Math.max(0, acceptorTimeout -
System.currentTimeMillis()), TimeUnit.MILLISECONDS);
Review comment:
This is actually a fix for NetworkFailureFailoverTest. So no need for a test.
(@brusdev please mention this is fixing networkFailureFailoverTest after
reapplying the commit)
NetworkFailureFailoverTest was actually added to prevent a situation where a
network card gone wouldn't prevent a server from stopping.
Instead of hunging during a shutdown the server will wait on a timeout, and
the process will die and the OS will take care of cleaning up resources on that
failure case.
On a regular scenario these will run really fast and never take very long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
