franz1981 commented on a change in pull request #2727: ARTEMIS-2394 Improve
scheduling sync for AMQPConnectionContext
URL: https://github.com/apache/activemq-artemis/pull/2727#discussion_r304893899
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
##########
@@ -87,9 +92,8 @@
private final boolean useCoreSubscriptionNaming;
- private boolean isSchedulingCancelled;
- private ScheduledFuture scheduledFuture;
- private final Object schedulingLock = new Object();
+ private final ScheduleOperator scheduleOp = new ScheduleOperator(new
ScheduleRunnable());
+ private final AtomicReference<Future> scheduledFutureRef = new
AtomicReference(VOID_FUTURE);
Review comment:
Please use Future<?> , do not use the raw type if possible...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
