clebertsuconic commented on a change in pull request #2741: ARTEMIS-2415 
JDBCJournal miss pending tasks during shutdown
URL: https://github.com/apache/activemq-artemis/pull/2741#discussion_r305345190
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
 ##########
 @@ -86,6 +87,8 @@
 
    protected ReplicationManager replicator;
 
+   protected final AtomicInteger deletingLargeMessageTasks = new 
AtomicInteger(0);
 
 Review comment:
   Take a look on ReusableLatch...
   
   I created ReusableLatch for situations like this.
   
   you make it a final... and you away(0) until it gets to 0.
   
   it's the same overhead as an AtomicINteger
   same usability as a CountDownLatch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to