clebertsuconic commented on a change in pull request #2769: ARTEMIS-2414 Sync
before closing file in case data loss
URL: https://github.com/apache/activemq-artemis/pull/2769#discussion_r308528264
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/LargeServerMessageImpl.java
##########
@@ -298,7 +298,7 @@ public int getBodyBufferSize() {
} finally {
if (closeFile) {
try {
- file.close();
+ file.close(false);
Review comment:
these will cause the channel to not flush, correct?
Why you making this change?
The thing is, I;ve run the testsuite after these changes and there are files
leaking.
I'm running it one more time but this is the only commit after it started to
fail. And I'm a bit confused about this after I merged and looking at the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
