michaelpearce-gain commented on a change in pull request #2775: ARTEMIS-2435
Configuration on device-block-size through CLI / broker.xml
URL: https://github.com/apache/activemq-artemis/pull/2775#discussion_r309088480
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/utils/XMLConfigurationUtil.java
##########
@@ -44,7 +44,6 @@ public static final Double getDouble(final Element e,
validator.validate(name, val);
return val;
} else {
- validator.validate(name, def);
Review comment:
Surely though it would be valid for someone to set a default value, as such
whilst a bit backwards, this would actually be (from unit testing) validate
that the validators set allow for the default value. If they dont and they
fail, then the validator isnt correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
