clebertsuconic commented on a change in pull request #2775: ARTEMIS-2435
Configuration on device-block-size through CLI / broker.xml
URL: https://github.com/apache/activemq-artemis/pull/2775#discussion_r309519331
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/utils/XMLConfigurationUtil.java
##########
@@ -44,7 +44,6 @@ public static final Double getDouble(final Element e,
validator.validate(name, val);
return val;
} else {
- validator.validate(name, def);
Review comment:
@michaelandrepearce well.. I don't see a point on that.. really.
It's moot, it's dead code.
I know that piece of code from the day it was written. it was just an
utility class, and the default value was not meant to be evaluated.
If you select your default value, it sure is intended to be returned as a
value, no need for validations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
