jbertram commented on a change in pull request #2790: ARTEMIS-2449 limit size 
of producer details
URL: https://github.com/apache/activemq-artemis/pull/2790#discussion_r312158464
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
 ##########
 @@ -175,7 +176,7 @@
    private final OperationContext context;
 
    // Session's usage should be by definition single threaded, hence it's not 
needed to use a concurrentHashMap here
-   protected final Map<SimpleString, Pair<Object, AtomicLong>> 
targetAddressInfos = new HashMap<>();
+   protected final Map<SimpleString, Pair<Object, AtomicLong>> 
targetAddressInfos = new MaxSizeMap<>(100);
 
 Review comment:
   There won't be any error. The map will just silently drop the oldest entry 
when the maxSize is hit. You'll be able to send to any destination again that 
was dropped previously due to maxSize. This information is only for 
administrative use.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to