michaelandrepearce edited a comment on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521123570 So i checked, the bridging code (e.g. intra cluster etc) encodes the message natively then embeds inside a core, as such the original message is fully preserved as is. This just then leaves two issue areas: 1) Large Messages 2) Conversion to Core Currently core doesn't support complex types, as such i think its wrong to leach AMQP encoding into core, as people could start relying on that. Either we should support complex types in core properly or we don't support and those are dropped. Reason for this is what occurs when other protocols support complex types we will be left with a legacy of AMQP encoded inside core. Re large messages this just sounds like we simply aren't fully supporting AMQP large messages there are a number of issues i understand in this area, thus why Clebert wanted to make Native large message support a blocker ticket for 2.8 (shame this didnt happen), this is known, either we need to support them or we don't. As such i see a few better options here: 1) Support Large Messages for AMQP fully 2) Support complex types in CORE 3) Support 1 & 2 Im against having a solution that leaks AMQP encoding into CORE. just as much as i know we dont like to modify AMQP in transit. I think this should be a no go area.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
