franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521550401 @michaelandrepearce Agree, but nonetheless my comment on the code hold: ``` // Older versions of artemis don't send the nodeID in BackupRequestMessage: // in this case we cannot trust the request, making the requesting server // to pair with this server in any case. ``` Old servers cannot be trusted, because they don't provide enough information to pair with new ones ie the colocated shared store with group name wasn't a feature correctly implemented. If I let them behave as before it can break a new cluster: atm i can't see solutions to preserve a partial cluster upgrade.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
