michaelpearce-gain commented on a change in pull request #2791: ARTEMIS-2450
page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315288710
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
##########
@@ -1756,17 +1758,17 @@ private void parseClusterConnectionConfiguration(final
Element e, final Configur
double retryIntervalMultiplier = getDouble(e,
"retry-interval-multiplier",
ActiveMQDefaultConfiguration.getDefaultClusterRetryIntervalMultiplier(),
Validators.GT_ZERO);
- int minLargeMessageSize = getTextBytesAsIntBytes(e,
"min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE,
Validators.GT_ZERO);
+ int minLargeMessageSize = getTextBytesAsIntBytes(e,
"min-large-message-size", ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE,
Validators.POSITIVE_INT);
long maxRetryInterval = getLong(e, "max-retry-interval",
ActiveMQDefaultConfiguration.getDefaultClusterMaxRetryInterval(),
Validators.GT_ZERO);
int initialConnectAttempts = getInteger(e, "initial-connect-attempts",
ActiveMQDefaultConfiguration.getDefaultClusterInitialConnectAttempts(),
Validators.MINUS_ONE_OR_GE_ZERO);
int reconnectAttempts = getInteger(e, "reconnect-attempts",
ActiveMQDefaultConfiguration.getDefaultClusterReconnectAttempts(),
Validators.MINUS_ONE_OR_GE_ZERO);
- int confirmationWindowSize = getTextBytesAsIntBytes(e,
"confirmation-window-size",
ActiveMQDefaultConfiguration.getDefaultClusterConfirmationWindowSize(),
Validators.GT_ZERO);
+ int confirmationWindowSize = getTextBytesAsIntBytes(e,
"confirmation-window-size",
ActiveMQDefaultConfiguration.getDefaultClusterConfirmationWindowSize(),
Validators.POSITIVE_INT);
Review comment:
revert not needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
