clebertsuconic commented on a change in pull request #2803: ARTEMIS-2458 Fix
AMQP Transaction Rollback Ordering
URL: https://github.com/apache/activemq-artemis/pull/2803#discussion_r315954798
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
##########
@@ -405,7 +405,11 @@ public void ack(Transaction transaction, Object
brokerConsumer, Message message)
public void cancel(Object brokerConsumer, Message message, boolean
updateCounts) throws Exception {
OperationContext oldContext = recoverContext();
try {
- ((ServerConsumer)
brokerConsumer).individualCancel(message.getMessageID(), updateCounts);
+ try {
+ ((ServerConsumer)
brokerConsumer).individualCancel(message.getMessageID(), updateCounts);
+ } catch (IllegalStateException e) {
+ //Ignore this silently, can occur if already cancelled.
Review comment:
nit-pick: can you log.debug here instead?
Although I could ammend it myself during merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
