gemmellr commented on issue #2803: ARTEMIS-2458 Fix AMQP Transaction Rollback Ordering URL: https://github.com/apache/activemq-artemis/pull/2803#issuecomment-523370760 I know other solutions have been proposed now, I've not yet looked at them but will try to later, but for completeness of discussion here... The issue definitely isn't with the client, which is doing what is expected and required from a JMS and AMQP perspective (and as noted works fine against a variety of other servers), but as suggested is rather with the behaviour Artemis introduces itself during the overall process. I believe Clebert was quite right to be concerned about this change however. If this does what I think (and for it to make any different at all I'd guess must be, or something similar) then it wouldn't be a valid thing to do from an AMQP perspective, though I expect it would behave ok with Qpid JMS due to the clients overall [JMS] behaviour. AMQP transactions aren't session-wide the way e.g JMS ones are, they can mix with non-transacted delivery, there can be multiple transactions on a session at a time, or they can also (/do in some other clients) span multiple sessions, etc. As such rolling back an AMQP transaction does not itself affect delivery of messages that were never listed (by the client, in this and almost all cases) as being part of that transaction. There are also cases (which some other clients can/do also make use of) where even rolling back the transaction would still leave messages that were part of it live and allocated to the client.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
