michaelpearce-gain commented on a change in pull request #2802: ARTEMIS-2457
implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#discussion_r317417639
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -576,15 +612,17 @@ public QueueImpl(final long id,
if (this.addressInfo != null && this.addressInfo.isPaused()) {
this.pause(false);
}
+
+ this.ringSize = ringSize == null ? (addressSettingsRepository != null ?
addressSettingsRepository.getMatch(address.toString()).getDefaultRingSize() :
-1) : ringSize;
}
// Bindable implementation
-------------------------------------------------------------------------------------
@Override
public boolean allowsReferenceCallback() {
- // non descructive queues will reuse the same reference between multiple
consumers
+ // non destructive queues will reuse the same reference between multiple
consumers
// so you cannot really use the callback from the MessageReference
- return !nonDestructive;
+ return !isNonDestructive();
Review comment:
(nit)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
