cjwmorgan-sol commented on a change in pull request #20: AMQNET-602: Set
batchable flag to false for amqp transfer
URL: https://github.com/apache/activemq-nms-amqp/pull/20#discussion_r318777097
##########
File path: src/NMS.AMQP/Provider/Amqp/AmqpHandler.cs
##########
@@ -0,0 +1,44 @@
+using Amqp.Framing;
+using Amqp.Handler;
+
+namespace Apache.NMS.AMQP.Provider.Amqp
+{
+ internal class AmqpHandler : IHandler
+ {
+ private readonly AmqpConnection connection;
+
+ public AmqpHandler(AmqpConnection connection)
+ {
+ this.connection = connection;
+ }
+
+ public bool CanHandle(EventId id)
+ {
+ switch (id)
+ {
+ case EventId.SendDelivery:
+ case EventId.ConnectionRemoteOpen:
+ case EventId.ConnectionLocalOpen:
+ return true;
+ default:
+ return false;
+ }
+ }
+
+ public void Handle(Event protocolEvent)
+ {
+ switch (protocolEvent.Id)
+ {
+ case EventId.SendDelivery when protocolEvent.Context is
IDelivery delivery:
+ delivery.Batchable = false;
Review comment:
I verify 1. and 2. work for me using Helloworld and a broker.
I'm fine with having a separate PR to address this too.
I prefer option 3 as more fine control over QoS for publishing messages like
what qpid gives.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
