twood2k commented on issue #2817: Network check custom ping priority URL: https://github.com/apache/activemq-artemis/pull/2817#issuecomment-526390435 so sorry. this is my first time using git. only have used subversion and tfs on real projects. thanks for the help and cleaning things up and ill try not to let it happen again. ugh, didnt even think about the test thanks again and take care. -tom On Thu, Aug 29, 2019 at 6:40 PM clebertsuconic <[email protected]> wrote: > You made a mess on your PR here.. you don't need to keep every single > commit.. you can just squash all your changes and keep one change only. but > I was able to squash them and keep your ownership. > > I'm adding a test.. and I'm merging after I cleaned it up. but in the > future (that's for any git based project.. not just artemis), you should > cleanup your PR. you could: > > # 5 here is number of commits you have > # use the list to squash them, google for git rebase -i, you will go through an editor such as vi > git rebase -i HEAD~5 > git push origin <your_branch_name> -f > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/activemq-artemis/pull/2817?email_source=notifications&email_token=ABHAZIBUDWN7JRVMQPKB6HLQHBF45A5CNFSM4ISEXXPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QAYSA#issuecomment-526388296>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABHAZICP3XC4N2HIIDFEPYTQHBF45ANCNFSM4ISEXXPA> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
