wy96f commented on issue #2703: ARTEMIS-2380 Fix delivering message in the case of consume close URL: https://github.com/apache/activemq-artemis/pull/2703#issuecomment-526421999 > This goes back to note the linger messages can be tracked at consumer level or even the server session. not queue though. E.g. if the issue is consumer is closed but session not committed, then it seems more logical that its the sessions responsibility to track and to have the logic within the session rollback/commit logic. > Having it at the queue level i can just see is prone to leaks like we have had other places which by putting the logic and ownership into the correct place resolved the leak and also cleaned up. Yes, we can track linger messages at consumer or session level. Linger consumer should also be tracked in queue, otherwise i'm not sure how to get linger messages without going through consumer while calling QueueImpl::getDeliveringMessages. Moreover in our case, we need to know which consumer is closed with these linger messages by which we can locate ip address where problem occurs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
