wy96f edited a comment on issue #2832: ARTEMIS-2482 Large messages could leak 
native ByteBuffers
URL: https://github.com/apache/activemq-artemis/pull/2832#issuecomment-530283213
 
 
   > @wy96f
   > 
   > > PooledByteBufAllocator::directBuffer uses java's ThreadLocal. Wouldn't 
this result in leak in the case if thread terminates due to idle timeout as in 
#2199 ?
   > 
   > Do you mean the thread local arena? Or the thread local NIO ByteBuffer?
   > Anyway, at the end of its usage we always release the `ByteBuf` and Netty 
will take care to release any referenced resources: it's a pool so it leaks "by 
definition"
   
   I mean tinySubPageDirectCaches/smallSubPageDirectCaches/normalDirectCaches 
in PoolThreadCache. Memory would be added into these caches first if 
released(not yet into shared arena). Given PoolThreadCache is thread local, 
would theses caches leak if thread terminates?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to