Havret commented on a change in pull request #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#discussion_r323418968
##########
File path: src/NMS.AMQP/NmsMessageConsumer.cs
##########
@@ -219,19 +225,24 @@ private void DeliverNextPending()
{
var envelope = messageQueue.DequeueNoWait();
if (envelope == null)
+ {
+ if (Tracer.IsDebugEnabled)
+ Tracer.Debug($"No message available for
delivery.");
+
return;
+ }
if (IsMessageExpired(envelope))
{
if (Tracer.IsDebugEnabled)
- Tracer.Debug($"{Info.Id} filtered expired
message: {envelope.Message.NMSMessageId}");
+ Tracer.Error($"{Info.Id} filtered expired
message: {envelope.Message.NMSMessageId}");
DoAckExpired(envelope);
}
else if (IsRedeliveryExceeded(envelope))
{
if (Tracer.IsDebugEnabled)
- Tracer.Debug($"{Info.Id} filtered message
with excessive redelivery count: {envelope.RedeliveryCount}");
+ Tracer.Error($"{Info.Id} filtered message
with excessive redelivery count: {envelope.RedeliveryCount}");
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
