michaelandrepearce commented on a change in pull request #2834: ARTEMIS-2488: 
Handle the case where source address is null
URL: https://github.com/apache/activemq-artemis/pull/2834#discussion_r324272574
 
 

 ##########
 File path: 
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerSenderContext.java
 ##########
 @@ -319,7 +319,7 @@ public void initialise() throws Exception {
          if (CompositeAddress.isFullyQualified(source.getAddress())) {
             addressToUse = 
SimpleString.toSimpleString(CompositeAddress.extractAddressName(source.getAddress()));
             queueNameToUse = 
SimpleString.toSimpleString(CompositeAddress.extractQueueName(source.getAddress()));
-         } else {
+         } else if (source.getAddress() != null) {
 
 Review comment:
   An alternate is to use the static method on SimpleString to convert String 
to SimpleString which has the null check. Tbh we should probable remove the 
public constructor on SimpleString to avoid such issues. E.g. every bit of code 
should use the safe static method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to