clebertsuconic commented on a change in pull request #2841: Simplifying Scale 
down remove queue logic
URL: https://github.com/apache/activemq-artemis/pull/2841#discussion_r325310043
 
 

 ##########
 File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ScaleDownRemoveSFTest.java
 ##########
 @@ -133,15 +115,8 @@ public void testScaleDownCheckSF() throws Exception {
       removeConsumer(0);
 
       //check
-      result = servers[1].queueQuery(sfQueueName);
-      AddressQueryResult result2 = servers[1].addressQuery(sfQueueName);
-      if ("true".equals(option)) {
-         assertFalse(result.isExists());
-         assertFalse(result2.isExists());
-      } else {
-         assertTrue(result.isExists());
-         assertTrue(result2.isExists());
-      }
+      Assert.assertFalse(servers[1].queueQuery(sfQueueName).isExists());
+      Assert.assertFalse(servers[1].addressQuery(sfQueueName).isExists());
 
 
 Review comment:
   @gaohoward perhaps you could send a PR later because I can't find where to 
add the check.
   
   I can only see 2 servers here, and one of them died, leaving us with just 
servers[1]. I guess I don't understand what you meant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to