franz1981 commented on a change in pull request #2832: ARTEMIS-2482 Large 
messages could leak native ByteBuffers
URL: https://github.com/apache/activemq-artemis/pull/2832#discussion_r325575480
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/LargeServerMessageImpl.java
 ##########
 @@ -511,6 +512,44 @@ protected void closeFile() throws Exception {
       }
    }
 
+   private static int read(final SequentialFile file, final ByteBuffer 
bufferRead) throws Exception {
 
 Review comment:
   > If we use netty pools, we need to read the file every time we read a 
message, right? Will this somewhat affect the perf?
   We need to find a proper solution, but is a leak and we use a heap buffer 
too there so it means a leak on IOUtil too...
   I see the same on decoding side for replicated files and on encoding side 
for non netty connections...basically everytime we performa FileChannel ops 
with heap ByteBuffers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to