ecki commented on a change in pull request #2839: [ARTEMIS-2490] Prevent 
NumberFormatExc when reading large message
URL: https://github.com/apache/activemq-artemis/pull/2839#discussion_r325603833
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
 ##########
 @@ -369,12 +369,11 @@ protected SequentialFile createFileForLargeMessage(final 
long messageID, final b
       LargeMessagePersister.getInstance().decode(buff, largeMessage);
 
       if (largeMessage.containsProperty(Message.HDR_ORIG_MESSAGE_ID)) {
-         // for compatibility: couple with old behaviour, copying the old file 
to avoid message loss
-         long originalMessageID = 
largeMessage.getLongProperty(Message.HDR_ORIG_MESSAGE_ID);
 
 Review comment:
   i answered in jira, or do you prefer to discuss here (short form, reason for 
jms id in orig core property is unclear)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to