cjwmorgan-sol commented on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533216107
 
 
   Sorry I got preoccupied for the last couple of days.
   Based on what @michaelandrepearce said for application throwing exceptions 
in Listeners to trigger failback. I really don't think that should be 
intentionally based on JMS spec 1.1 section 4.5.2 application should be 
handling all exceptions including runtime exception, at least for well behaved 
applications. 
   
   My understanding is applications should not be throwing any exceptions 
intentionally from the listener. In qpid jms the message listener can not throw 
any exceptions except for a java runtime exception (the only exceptions that 
can be thrown from anywhere). Qpid jms does not have to handle this since the 
java language prevent applications from writing code that can produce 
exceptions in the first place.  C# is not the same in this regard, just adding 
a try and catch into the message listener is not enough, so the provider should 
handle the general exception with more scrutiny resulting in the need for a log 
or at least some form of notification. Although based on the other nms provider 
(openwire) a general exception from a message listener event is an error log. 
   
   I would strongly advocate for the provider to have some form of notification 
from an exception thrown by a messageListener event. I would suggest that a log 
at an appropriate level depending on the exception (at least warning for 
general exception and at least debug for SystemException) would suffice for now 
until a more advanced system like qpid jms message tracing system is required.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to