Havret commented on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533690118
 
 
   I'm not a Java expert, but what I remember from Uncle Bob's Clean Code I 
read years ago, you shouldn't use checked exception as they violate open closed 
principle. I don't know how it looks like in the real world applications, but I 
assume that RuntimeException is the base for all the exception that people are 
normally throwing. 
   
   I'm not particularly happy with the idea of pretending that .NET 
SystemExceptions are equivalent of Java Run-time Exceptions, and treating them 
differently. All .NET exceptions are run-time exceptions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to