Havret edited a comment on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533690118
 
 
   I'm not a Java expert, but what I remember from Uncle Bob's Clean Code I 
read years ago, you shouldn't use checked exception as they violate open closed 
principle. I don't know how it looks like in the real world applications, but I 
assume that RuntimeException is the base for all the exception that people are 
normally throwing. 
   
   I'm not particularly happy with the idea of pretending that .NET 
SystemExceptions are equivalent of Java Run-time Exceptions, and treating them 
differently. All .NET exceptions are run-time exceptions. There concept of 
checked exceptions doesn't exist (glory be) in .NET world, hence I wouldn't pay 
too much attention to them. 
   
   Taking into account what Michael said, my inclination would be not to add 
this logging after all. We can address this problem (if there is a real 
problem) in the future by implementing message tracing system, but for now I 
wound give it a rest. Especially after I saw that some people are throwing 
exceptions from listener's callbacks in order to reject messages and this is, 
for whatever reason, valid scenario to them. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to