franz1981 commented on a change in pull request #2844: ARTEMIS-1811 NIO Seq
File should use RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#discussion_r326849697
##########
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/nio/NIOSequentialFile.java
##########
@@ -173,6 +173,40 @@ public int read(final ByteBuffer bytes) throws Exception {
return read(bytes, null);
}
+ //On *nix platform is the size by which RandomAccessFile write/read are
performed using a
+ //stack-allocated copy of the java byte[]
Review comment:
This was just a POC commit to mitigate the issue , but we can discuss on the
comments about it :)
Thanks to looking at it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
