franz1981 commented on a change in pull request #2845: ARTEMIS-2336 Use zero 
copy to replicate journal/page/large message file (AGAIN)
URL: https://github.com/apache/activemq-artemis/pull/2845#discussion_r326903252
 
 

 ##########
 File path: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
 ##########
 @@ -151,6 +151,11 @@ public ChannelImpl(final CoreRemotingConnection 
connection,
       }
 
       this.interceptors = interceptors;
+      //zero copy transfer is initialized only for replication channels
 
 Review comment:
   Right now is not and I've added an assert to make the test suite to fail on 
it, but we can always configure the Netty pipeline to handle them with no harm, 
If is more clear..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to