gaohoward commented on issue #2846: ARTEMIS-2500 CoreMessage doesn't make a ful copy of its props URL: https://github.com/apache/activemq-artemis/pull/2846#issuecomment-534108542 I find there are 2 copy methods in LargeServerMessageImpl. One is copy() which uses copy constructor. The other is copy(newId) which does not. If we can use copy constructor in both copy methods then this PR is not necessary. In the case the copyHeadersAndProperties() shall be removed because it can cause subtle errors described above and hard to find.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
