k-wall commented on a change in pull request #2847: ARTEMIS-2494: [AMQP] Allow
Modified disposition to be used signal address full to a sending peer
URL: https://github.com/apache/activemq-artemis/pull/2847#discussion_r327491228
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
##########
@@ -264,6 +264,8 @@
private static final String AMQP_USE_CORE_SUBSCRIPTION_NAMING =
"amqp-use-core-subscription-naming";
+ private static final String AMQP_USE_MODIFIED_FOR_TRANSIENT_DELIVERY_ERRORS
= "amqp-use-modified-for-transient-delivery-errors";
Review comment:
@clebertsuconic configuration mechanism changed as suggested.
on the name, I can't think how to shorten significantly without losing
important information. Best alternative I can up with was
`amqpSendModifiedForTransientErrors` which save a few characters. FWIW I don't
think too many users will be configuring this option. I'm happy to rename as
you see fit. Let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
