k-wall edited a comment on issue #2847: ARTEMIS-2494: [AMQP] Allow Modified 
disposition to be used signal address full to a sending peer
URL: https://github.com/apache/activemq-artemis/pull/2847#issuecomment-534963469
 
 
   My initial patch missed the code path where the address full policy is BLOCK 
and the paging store signals itself full.    Previously reject would be sent 
unconditionally.  Now Modified is sent if enabled/supported on the link as per 
the other case.
   
   There is a small behavioural change in this patch (a25a289).  Previously on 
the BLOCK code path the Reject for an address-full would be sent with a 
`resource-limit-exceeded `whereas the other code path would send a Reject for 
an address-full with a condition `failed`.  This patch uses 
`resource-limit-exceeded` consistently.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to