clebertsuconic commented on a change in pull request #2861: ARTEMIS-2515
pageIterator.hasNext spends too much time in the case of no messages matched
URL: https://github.com/apache/activemq-artemis/pull/2861#discussion_r334007680
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -2942,7 +2946,14 @@ private void depage(final boolean scheduleExpiry) {
this.directDeliver = false;
int depaged = 0;
- while (timeout > System.currentTimeMillis() && needsDepage() &&
pageIterator.hasNext()) {
+ while (timeout > System.nanoTime() && needsDepage()) {
+ int status = pageIterator.tryNext();
+ if (status == 2) {
+ continue;
+ } else if (status == 0) {
+ break;
+ }
+
Review comment:
Same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
