michaelandrepearce commented on a change in pull request #2872: ARTEMIS-2531:
Fix filter in FederatedQueue to prevent infinite consumer creation in a
circular or bidrectional setup
URL: https://github.com/apache/activemq-artemis/pull/2872#discussion_r339189057
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/federation/queue/FederatedQueue.java
##########
@@ -63,7 +63,7 @@ public FederatedQueue(Federation federation,
FederationQueuePolicyConfiguration
Objects.requireNonNull(config.getName());
this.config = config;
this.priorityAdjustment = federationUpstream.getPriorityAdjustment() +
(config.getPriorityAdjustment() == null ? -1 : config.getPriorityAdjustment());
- String metaDataFilterString = config.isIncludeFederated() ? null :
FederatedQueueConsumer.FEDERATION_NAME + " IS NOT NULL";
+ String metaDataFilterString = config.isIncludeFederated() ? null :
"hyphenated_props:" + FederatedQueueConsumer.FEDERATION_NAME + " IS NOT NULL";
Review comment:
If you want to restrict that then you should use hops to limit it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
