cshannon commented on issue #2872: ARTEMIS-2531: Fix filter in FederatedQueue to prevent infinite consumer creation in a circular or bidrectional setup URL: https://github.com/apache/activemq-artemis/pull/2872#issuecomment-546481206 @michaelandrepearce - As a follow up to maybe make it more clear, the fix is fixing the flag that already exists called `include-federated` as described here: https://activemq.apache.org/components/artemis/documentation/latest/federation-queue.html and not changing behavior at all. If anything this is making sure the intended behavior actually happens correctly as documented because as you will see if you run the FederatedQueueTest I updated unchanged without the fix it breaks because a ton of consumers get created when they should have been excluded as the filter that was created (by the flag `include-federated` being false) doesn't work as intended because of the hyphen.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
