michaelandrepearce commented on a change in pull request #2897: ARTEMIS-2558 
Add the commented out args to dump the java heap on OOME
URL: https://github.com/apache/activemq-artemis/pull/2897#discussion_r349182316
 
 

 ##########
 File path: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
 ##########
 @@ -112,6 +112,11 @@ if [ -z "$WILDFLY_COMMON" ] ; then
   WILDFLY_COMMON="$ARTEMIS_HOME/lib/${wildfly-common}"
 fi
 
+if [ -f "$ARTEMIS_INSTANCE/log/oomheapdump.hprof" ] ; then
 
 Review comment:
   Comment this, also best to use a var for the filename as everyone will have 
their own naming conventions
    Lastly you may want to have a max history else you can easily fill disk

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to