clebertsuconic commented on a change in pull request #2904: ARTEMIS-2564
retryMessages incorrectly removes msgs
URL: https://github.com/apache/activemq-artemis/pull/2904#discussion_r353374827
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -1996,8 +1980,7 @@ private int iterQueue(final int flushLimit,
}
if (filter1 == null || filter1.match(ref.getMessage())) {
- messageAction.actMessage(tx, ref);
- if (remove) {
+ if (messageAction.actMessage(tx, ref)) {
Review comment:
I give up... and there's no need for that..
I will merge it.. if anyone has a strong opinion of adding the test.. he's
welcome to do it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
