michaelandrepearce commented on a change in pull request #2913: ARTEMIS-2571
Remove synchronization of ActiveMQServerImpl#getSessions()
URL: https://github.com/apache/activemq-artemis/pull/2913#discussion_r356140076
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -294,7 +294,7 @@
private FileStoreMonitor fileStoreMonitor;
- private final Map<String, ServerSession> sessions = new
ConcurrentHashMap<>();
+ private final ConcurrentMap<String, ServerSession> sessions = new
ConcurrentHashMap<>();
Review comment:
Can a perf test or some other benefit for this change be provided. This is
core parts of the broker where historically concurrent issues introduced by
such small changes have had tragic effects. Comment is about whole pr with
removal of method level syncs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
