clebertsuconic commented on issue #2912: NO-JIRA Minor code improvement in QueueImpl URL: https://github.com/apache/activemq-artemis/pull/2912#issuecomment-564124599 Most of the changes here are harmless... (verifying the flag before a method result, that'a s minimal change). However the actual code change performed here scares me, especially on a component like this... on a rare usecase (lingering TXs).. this may break 1% of the usecases when using XA and that kind of thing, and that kind of thing it's not easy to debug remotely.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
