sebthom commented on a change in pull request #2912: NO-JIRA Minor code
improvement in QueueImpl
URL: https://github.com/apache/activemq-artemis/pull/2912#discussion_r356177927
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -129,9 +129,9 @@
protected static final int CRITICAL_CHECK_DEPAGE = 4;
private static final Logger logger = Logger.getLogger(QueueImpl.class);
- private static final AtomicIntegerFieldUpdater dispatchingUpdater =
AtomicIntegerFieldUpdater.newUpdater(QueueImpl.class, "dispatching");
- private static final AtomicLongFieldUpdater dispatchStartTimeUpdater =
AtomicLongFieldUpdater.newUpdater(QueueImpl.class, "dispatchStartTime");
- private static final AtomicLongFieldUpdater consumerRemovedTimestampUpdater
= AtomicLongFieldUpdater.newUpdater(QueueImpl.class,
"consumerRemovedTimestamp");
+ private static final AtomicIntegerFieldUpdater<QueueImpl>
dispatchingUpdater = AtomicIntegerFieldUpdater.newUpdater(QueueImpl.class,
"dispatching");
Review comment:
This just solves a lot of (16) compiler warnings. When declared:
"AtomicIntegerFieldUpdater is a raw type. References to generic type
AtomicIntegerFieldUpdater<T> should be parameterized"
When referenced: "Type safety: The method get(Object) belongs to the raw
type AtomicIntegerFieldUpdater. References to generic type
AtomicIntegerFieldUpdater<T> should be parameterized"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
