michaelandrepearce edited a comment on issue #2903: ARTEMIS-2565 - Add plugin support for Federated Queues/Addresses URL: https://github.com/apache/activemq-artemis/pull/2903#issuecomment-565676333 @cshannon as you would have seen, two main bits to address here. 1) logging anything that is info, warn, error should always have a logging code, and use a specific log method. 2) As plugins make things public, then interfaces should be extracted, so plugin takes interface, not the concrete implementation. Also should only expose what's needed e.g. getter fields methods, but maybe not every method?. Else will make any future refactoring on concrete classes, like just done in previous PR impossible. Apart from that looks good. (thumbs up)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
