wy96f commented on a change in pull request #2918: NO-JIRA minor changes on test
URL: https://github.com/apache/activemq-artemis/pull/2918#discussion_r358616397
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/AddressControlTest.java
##########
@@ -282,7 +281,7 @@ public void testGetNumberOfBytesPerPage() throws Exception
{
session.createQueue(address, address, true);
AddressControl addressControl = createManagementControl(address);
-
Assert.assertEquals(ActiveMQDefaultConfiguration.getDefaultJournalFileSize(),
addressControl.getNumberOfBytesPerPage());
Review comment:
It's not semantically right to compare `pageSizeBytes` with default journal
file size. The default page size should be AddressSettings.DEFAULT_PAGE_SIZE,
see
https://github.com/apache/activemq-artemis/blob/eb3c4931c2871a58fea9208eebaf90bc8ffbe462/artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java#L514
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
