Havret commented on a change in pull request #12: NMS 2.0 WIP
URL: https://github.com/apache/activemq-nms-api/pull/12#discussion_r371024909
##########
File path: src/nms-api/IMessage.cs
##########
@@ -100,5 +100,18 @@ public interface IMessage
/// The type name of this message.
/// </summary>
string NMSType { get; set; }
+
+ /// <summary>
+ /// When a message is sent, the NMSDeliveryTime header field is
+ /// left unassigned. After completion of the send or
+ /// publish method, it holds the delivery time of the message.
+ /// This is the the difference, measured in milliseconds,
+ /// between the delivery time and midnight, January 1, 1970
UTC.
+ ///
+ /// A message's delivery time is the earliest time when a JMS
provider may
+ /// deliver the message to a consumer. The provider must not
deliver messages
+ /// before the delivery time has been reached.
+ /// <summary>
+ DateTime NMSDeliveryTime { get; set; }
}
Review comment:
There are still a few properties and methods from the original jms api
missing:
```
byte[] NMSCorrelationIDAsBytes { get; set; }
DateTime NMSExpiration { get; set; }
T GetBody<T>();
bool IsBodyAssignableTo<T>();
```
I'm sure why in NMS API we have Properties property (non pun intended)
whereas in JMS there is direct access to fields from message interface, like
```
byte getByteProperty(String name) throws JMSException;
short getShortProperty(String name) throws JMSException;
int getIntProperty(String name) throws JMSException;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
