michaelandrepearce commented on a change in pull request #2951: Artemis-2563
Add option to create queue on all active clustered nodes
URL: https://github.com/apache/activemq-artemis/pull/2951#discussion_r371030139
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -272,6 +272,23 @@ public void onNotification(final Notification
notification) {
queueInfos.put(clusterName, info);
+ //Global queue creation fix
+ Binding binding = getBinding(routingName);
+
+ AddressSettings addressSettings =
addressSettingsRepository.getMatch(address.toString());
+
+ boolean clusteredQueues = addressSettings.getClusteredQueues();
Review comment:
should this not be a value that's configurable at the queue level, e.g.
under an address you may want one queue not clustered and another clustered. it
shouldn't be an all or nothing for all queues, e.g. address setting should be a
default to apply to queues beneath the address (where the default is false if
not set at all), but the actual value should be at the queue level, so that its
possible to configure some queues with and some queues not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
