jbonofre commented on a change in pull request #424: AMQ-5503: Improve
initscript, reintegrate changes
URL: https://github.com/apache/activemq/pull/424#discussion_r371211519
##########
File path: assembly/src/release/bin/activemq
##########
@@ -386,8 +362,8 @@ checkRunning(){
echo "ERROR: Pidfile '$ACTIVEMQ_PIDFILE' exists but contains no pid"
return 2
fi
- ACTIVEMQ_PID="`cat ${ACTIVEMQ_PIDFILE}`"
- RET="`ps -p "${ACTIVEMQ_PID}"|grep java`"
+ ACTIVEMQ_PID="`cat $ACTIVEMQ_PIDFILE`"
+ RET="`ps -p "$ACTIVEMQ_PID"|grep java`"
Review comment:
It's more portable to keep the genere ${xx} format IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
