michaelpearce-gain commented on a change in pull request #53: AMQNET-634: Use 4
as default msg priority
URL: https://github.com/apache/activemq-nms-amqp/pull/53#discussion_r374543790
##########
File path: test/Apache-NMS-AMQP-Test/NmsMessageProducerTest.cs
##########
@@ -77,7 +77,7 @@ public void TestGetDisableTimeStamp()
public void TestPriorityConfiguration()
{
IMessageProducer producer = session.CreateProducer(null);
- Assert.AreEqual(NMSConstants.defaultPriority, producer.Priority);
+ Assert.AreEqual(MsgPriority.BelowNormal, producer.Priority);
Review comment:
my point here is as per our discussion imagine the api values were changed
to fix more fully in correcting the api.... would want this to flag broken
immediately, where as relying on the api values ... it wouldnt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
