franz1981 commented on a change in pull request #2975: ARTEMIS-2617 Improve
AMQP Journal loading
URL: https://github.com/apache/activemq-artemis/pull/2975#discussion_r377296464
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java
##########
@@ -156,6 +157,72 @@ public void testCreateMessageForPersistenceDataReload()
throws ActiveMQException
assertEquals(TEST_TO_ADDRESS, message.getAddress());
}
+ @Test
Review comment:
In this case it would lead to a false positive, that's ok in our case, given
that is very unlikely that both values or keys are named similarly to a
specific existing symbol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services