jbertram commented on issue #2978: ARTEMIS-2563 Added option to create queues on all clustered nodes URL: https://github.com/apache/activemq-artemis/pull/2978#issuecomment-584721618 The test failures look legitimate to me since you've modified `org.apache.activemq.artemis.core.settings.impl.AddressSettings` and `org.apache.activemq.artemis.tests.compatibility.JournalCompatibilityTest` is failing at the point where it's trying to decode address settings. It looks to me like the problem is in `org.apache.activemq.artemis.core.settings.impl.AddressSettings#decode(org.apache.activemq.artemis.api.core.ActiveMQBuffer, boolean)` because you're not checking `buffer.readableBytes() > 0` when trying to decode your new parameter which fails on an old journal which doesn't have that set.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
