clebertsuconic commented on a change in pull request #2976: ARTEMIS-2325 + a
test fix
URL: https://github.com/apache/activemq-artemis/pull/2976#discussion_r377929374
##########
File path:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
##########
@@ -534,62 +524,56 @@ private CompletionListenerWrapper(CompletionListener
listener,
@Override
public void
sendAcknowledged(org.apache.activemq.artemis.api.core.Message clientMessage) {
- if (active.get()) {
- if (jmsMessage instanceof StreamMessage) {
- try {
- ((StreamMessage) jmsMessage).reset();
- } catch (JMSException e) {
- // HORNETQ-1209 XXX ignore?
- }
- }
- if (jmsMessage instanceof BytesMessage) {
- try {
- ((BytesMessage) jmsMessage).reset();
- } catch (JMSException e) {
- // HORNETQ-1209 XXX ignore?
- }
+ if (jmsMessage instanceof StreamMessage) {
+ try {
+ ((StreamMessage) jmsMessage).reset();
+ } catch (JMSException e) {
+ // HORNETQ-1209 XXX ignore?
Review comment:
not related to your change but can you please remove this XXX?
This is mark I used to add on code.
I don't recall if I did this, but this is a thing I used to do to mark the
code with stuff like During a big refactoring I would mark XXX, and remove it
before merging.. so it was intended to be removed from 10 years ago :)
you could replace this thing by just logger.debug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
